Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Gdp data #104

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Fix for Gdp data #104

merged 4 commits into from
Jul 29, 2024

Conversation

shahronak47
Copy link
Contributor

For this task https://app.clickup.com/t/8688xw9p1 , we are now saving gdp to Github using save_to_gh function available in this PR PIP-Technical-Team/pipfun#2 . After the data is updated in GitHub the hash for gdp would change and will allow to run the function when we call auto_aux_update().

@randrescastaneda
Copy link
Member

Hi @shahronak47 ,

Thank you. This looks great. Let's wait for this PR to be completed. Once it is done, I'll pump up the version of pipfun and then we make this release dependent on that version so that we won't encounter issues installing pipaux.

Thanks.

@randrescastaneda
Copy link
Member

Hi @shahronak47 ,

I pumped up pipfun to 0.0.2 to you can make pipaux depend on it via usethis::use_dev_package("pipfun", remote = "github::PIP-technical-team/pipfun@DEV")

Thanks.

@shahronak47
Copy link
Contributor Author

Hi @shahronak47 ,

I pumped up pipfun to 0.0.2 to you can make pipaux depend on it via usethis::use_dev_package("pipfun", remote = "github::PIP-technical-team/pipfun@DEV")

Thanks.

This is done.

@randrescastaneda randrescastaneda merged commit b620b1d into DEV Jul 29, 2024
@randrescastaneda randrescastaneda deleted the gdp-update branch July 29, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants