Skip to content

Fix SVGs #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix SVGs #881

wants to merge 2 commits into from
+9 −3

Conversation

seanlynchwv
Copy link
Contributor

@seanlynchwv seanlynchwv commented Sep 8, 2025 •
edited
Loading

Description

Adding custom SVGs now works

Fixed by #732 (comment)

Fixes # (issue)

#732

Checklist:

  • My CI is 🟢
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes
  • I have updated the changelog

@auto-assign auto-assign bot requested a review from Progi1984 September 8, 2025 16:18
@coveralls
Copy link

coveralls commented Sep 8, 2025 •
edited
Loading

Coverage Status

coverage: 91.644% (+0.001%) from 91.643%
when pulling 6ae84da on seanlynchwv:fix/svg-error
into 7018fd8 on PHPOffice:master.

@seanlynchwv
Copy link
Contributor Author

Not sure why this is failing now, was passing earlier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Awaiting requested review from Progi1984

Assignees

@Progi1984 Progi1984

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seanlynchwv @coveralls @Progi1984