Adding DaemonFactoryInterface::createDaemonFromStreamSocket #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test will pass after rebase on #59 |
Nyholm
added a commit
to Nyholm/FastCGIDaemon
that referenced
this pull request
Aug 7, 2018
|
PR is rebased |
|
The reason this was left out before is because it was impossible to support from the PHP5 extension that I was toying around with this branch. Maybe we add it in, and then if a PHP7 libfastcgi extension becomes available we throw an exception for drivers that can't support it? |
|
Sure. Let’s merge now and consider revert before 1.0 |
|
Lets postpone this PR then. |
Nyholm
added a commit
that referenced
this pull request
Aug 14, 2018
* Added changelog for 0.11.0 * Minor * Added changelog for #60 * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method was missing from the interface but existed in the implementation. This PR should me merged or
DaemonFactory::createDaemonFromStreamSocketshould be removed.