-
Notifications
You must be signed in to change notification settings - Fork 16
Make sure independent from ANY PSR7 implementation #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
composer.json
Outdated
"phpunit/phpunit": "^5.7.27", | ||
"symfony/http-foundation": "^3.4 || ^4.0", | ||
"zendframework/zend-diactoros": "^1.8", | ||
"nyholm/psr7-server": "dev-interface", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be 0.1.2 shortly
composer.json
Outdated
"symfony/http-foundation": "^3.4 || ^4.0", | ||
"zendframework/zend-diactoros": "^1.8", | ||
"nyholm/psr7-server": "dev-interface", | ||
"http-interop/http-factory-diactoros": "dev-master", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will release 1.0.0 when the psr for HTTP factories is released as a package (within few days)
Looks good, but won't that clash with this line which uses I'm also wondering if there's a sensible way for doing defaults, or some sort of helper function that removes the boiler plate. |
Yes, that line is not needed anymore after this PR is merged.
Im not sure. The |
c419445
to
ae21ab3
Compare
PR is rebased and dependecies are updated |
Looks good - I'm happy to merge. The README.md file will need updating too, or do that before tagging? |
I vote for a merge now. I’ll update the docs before tagging. |
PSR-17 (HTTP factories) has just been accepted. We should support ANY PSR-7 implementation.
Since we are working with ServerRequests it is a little more tricky. PSR-17 does not really help much here. I've created a "helper package" so one easily can create server requests. See https://github.com/Nyholm/psr7-server
With this PR:
Install
nyholm/psr7-server
and any PSR7 and PSR17 implementation.