Support multiple upload files #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
commented
Jul 30, 2018
src/Http/Request.php
Outdated
| 'size' => filesize($tmpPath), | ||
| ]; | ||
|
|
||
| if (!preg_match('|([^\[]+)(?:\[([^\]]+)\])*(\[\])?|', $fieldName, $matches)) { |
There was a problem hiding this comment.
This regex is not good enough. It does not pick up "foo" in two[foo][bar][].
Any ideas for improved regex?
Nyholm
force-pushed
the
support_multiple_upload_files
branch
from
eb2b5de to
7c78e6e
Compare
Nyholm
force-pushed
the
support_multiple_upload_files
branch
from
7c78e6e to
4b4dcf9
Compare
|
Really nice - thanks! Looks like a thorough test too! |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #37. I will rebase when it is merged.
We need to properly support field names like
foo[]andfoo[bar]. This PR will add such support.