More slash normalization #9
Merged
+74
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up on 5 When trying to run the tests on Windows, I ran into more issues with mixed slashes. As that means that the `normalizeSlashes()` functionality is needed in more places, I'm proposing to introduce a generic `Util\Functions` class for simple static methods which are needed in multiple places. Includes introducing dedicated tests for the `normalizeSlashes()` method.
Improves cross-platform compatibility of the code. With this additional change, the tests will pass on Windows as well, meaning that this part of the functionality should now also work on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move normalizeSlashes() to Util\Functions class
Follow up on #5
When trying to run the full test suite on Windows, I ran into more issues with mixed slashes.
As that means that the
normalizeSlashes()functionality is needed in more places, I'm proposing to introduce a genericUtil\Functionsclass for simple static methods which are needed in multiple places.Includes introducing dedicated tests for the
normalizeSlashes()method.I'd be happy to rename/move the class if you can think of a better name/path for it.
ViolationParser: implement use of Functions::normalizeSlashes()
Improves cross-platform compatibility of the code.
With this additional change, the tests will pass on Windows as well, meaning that this part of the functionality should now also work on Windows.