Jekyll refactor #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

afilina wants to merge 3 commits into main from jekyll-refactor

Collaborator

afilina commented Mar 30, 2021 •

edited

Loading

Fixes #12

Additional changes:

The phpunit.xml.dist was out of sync with the used version of PHPUnit
Simplify existing tests
Remove an unnecessary execution path
In addition to removing extra LF, also remove extra CRLF

afilina added 3 commits

March 30, 2021 03:17


          Refactor generators to use a formatter instead of inheritance

b4ead39


          Increase test coverage for MarkdownFormatter

38f532c


          Removing impossible scenario, since strings are always non-empty

384bfe2

afilina requested a review from jrfnl

March 30, 2021 16:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet