Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release PHPCSExtra 1.2.0 #296

Merged
merged 30 commits into from
Dec 2, 2023
Merged

Release PHPCSExtra 1.2.0 #296

merged 30 commits into from
Dec 2, 2023

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Dec 1, 2023

Release checklist

Target release date: Dec 2, 2023.

General

Release

  • Merge this PR
  • Make sure all CI builds are green.
  • Tag and create a release (careful, GH defaults to develop!) & copy & paste the changelog to it.
    ✏️ Check if anything from the link collection at the bottom of the changelog needs to be copied in!
  • Make sure all CI builds are green.
  • Close the milestone
  • Open a new milestone for the next release
  • If any open PRs/issues which were milestoned for this release did not make it into the release, update their milestone.
  • Fast-forward develop to be equal to stable

Publicize

  • Tweet about the release.

jrfnl and others added 28 commits September 21, 2023 09:50
... to detect double negatives (`!!`) and advise to use a boolean cast instead.

The sniff will correctly handle a situation where even more consecutive not operators are found.

In the case, the number of operators is uneven, it will auto-fix to a single not operator.

And when a double not operator is found before an expression involving `instanceof`, the error will still be thrown, but not auto-fix as the `instanceof` operator is nested right between the `!` operator and a `(bool)` cast operator precedence wise, so auto-fixing without also adding parentheses would change the behaviour of the code.

Includes fixer.
Includes unit tests.
Includes documentation.

Ref: https://www.php.net/manual/en/language.operators.precedence.php
... to enforce that the "PHP" in a PHP open tag is lowercase.

Includes fixer.
Includes unit tests.
Includes documentation.
Includes metrics.
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
…hp-tag-sniff

✨ New `Universal.PHP.LowercasePHPTag` sniff
…ative-sniff

✨ New `Universal.CodeAnalysis.NoDoubleNegative` sniff
…/actions/setup-node-4

GH Actions: Bump actions/setup-node from 3 to 4
... as the old URLs are no longer valid.
... as that is also a YAML file.

Includes minor formatting fixes to the PHPStan config file
Commit PHPCSStandards/.github@15b6006 added a `SECURITY.md` file which is applicable for all repos in this organization and is sufficient.

This means the `SECURITY.md` file in the repo can now be removed.
Simplify the code coverage workflow by removing the dependency on the `php-coveralls/php-coveralls` package and switching to the `coverallsapp/github-action` action runner, which, as of the release of the [0.6.5 version of the Coverage Reporter](https://github.com/coverallsapp/coverage-reporter/releases/tag/v0.6.5) now natively supports the Clover format.

The `COVERALLS_TOKEN` can now be removed from Settings -> Secrets.

Ref: lemurheavy/coveralls-public#1721
…to-coveralls-reporter

GH Actions: switch to Coveralls action runner to upload reports
Some standards may want to have different rules when
the array closer is in the same line than the last element.

When that happens, the new *CloserSameLine errors are
emitted, allowing to disable them via ruleset. Only for
MultiLine cases, they don't make sense in SingleLine ones.

Fixes #283
Split the errors, adding the *CloserSameLine ones
This is a quite straight-forward workflow to just remove some labels which should only be on open issues/open PRs and which should be removed once an issue or PR has been closed/merged.

Just attempting to reduce yet some more manual labour.
…move-some-labels

GH Actions: automate some label management
This is a new feature available since Composer 2.6.0, which was released a little while ago.

When this key is added, it will also show a link to the security policy on Packagist.

The security policy itself has been added to the organisation `.github` repository and can be accessed via the `security/policy` link on each repo.

Refs:
* https://github.com/composer/composer/releases/tag/2.6.0
* composer/composer#11271
* composer/packagist#1353
…rity-link

Composer.json: add link to security policy
... which is expected later today.

* Builds against PHP 8.3 are no longer allowed to fail.
* Add _allowed to fail_ build against PHP 8.4.
* Update the "tested against" badge in the README.

Includes minor tweak to the badge ordering.
…-update

GH Actions: update for the release of PHP 8.3
Copy/pasta. This sniff does not record metrics.
…s-minor-clean-up

Universal/NoUselessAliases: remove unused constant
... to enforce that the concatenation operator for multi-line concatenations is in a preferred position, either always at the start of the next line or always at the end of the previous line.

The preferred position is configurable via an `allowOnly` property, which accepts the text strings "start" or "end".
The default is "start".

Includes fixer.
Includes unit tests.
Includes documentation.
Includes metrics.
…ion-sniff

✨ New `Universal.Operators.ConcatPosition` sniff
…tra-1.2.0

Changelog and readme updates for PHPCSExtra 1.2.0
@jrfnl jrfnl added this to the 1.2.0 milestone Dec 1, 2023
@jrfnl jrfnl merged commit 78b2cae into stable Dec 2, 2023
@jrfnl
Copy link
Member Author

jrfnl commented Dec 2, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants