feat: graceful API contract for malformed requests (P2) - #11
Merged
Conversation
- Add GlobalExceptionHandler (@RestControllerAdvice): a malformed or empty request body now returns HTTP 200 with a PrAnalysisResponse envelope (overallRisk=PARSING_ERROR) instead of Spring's default 400, honoring the documented always-200 graceful-degradation contract. - Extract PayloadTooLargeException to a public top-level class; the advice maps an over-limit chunked body to 413, consistent with the P0 size filter (this case previously leaked through as a 400). - Tests: GlobalExceptionHandlerTest (unit, both branches) and a @WebMvcTest covering malformed/empty -> 200 envelope and valid -> service delegation. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
💥 Blast Radius AnalysisOverall Risk: ❓ UNKNOWN 🔍 Impact Areas
🧪 Suggested Tests
Analyzed by Blast Radius (Spring Boot + Groq LLM) • 2026-06-15 |
PG1204
added a commit
that referenced
this pull request
Jul 7, 2026
Merge pull request #11 from PG1204/p2-api-contract
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the API-contract gap: malformed input now follows the same graceful-degradation contract as every other failure path.
@RestControllerAdvicemaps an unreadable/empty request body to HTTP 200 with aPrAnalysisResponseenvelope (overallRisk=PARSING_ERROR) instead of Spring's default 400.PayloadTooLargeExceptionto a public top-level class; an over-limit chunked body (no Content-Length) now returns 413, consistent with the P0 size-limit filter (previously surfaced as 400).Testing
GlobalExceptionHandlerTest— unit, both branches (200 envelope + 413).AnalysisControllerWebTest—@WebMvcTest: malformed/empty → 200 envelope, valid → delegates to service.GoldenDiffTestexcluded — needs real key + network).Notes
PARSING_ERRORvalue (no enum change).