-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CH10 pick up address from interface #2293
Conversation
Thank you. I will check this, but I'll be busy the coming weeks so it may be a while. |
I haven't actually built and tested this on a CH10 system yet. Will do that next. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried testing this out by build an EMULATOR=pdp10-kl version of ITS. The network didn't come up, and I noticed that MYCHDR wasn't defined. It turned out that the ITS built by this build was configured for the machine MX and not KL, and MX doesn't have the chaosnet definitions, as KL does. I'm going to debug this and fix.
So let's not merge this until I've proven that it works on either a pdp10-kl or a pdp10-ka ITS.
Also, you need to update the version number on chaos.290 and its.1651.
In the booted KL instance, I manually tried to build ITS. I see the following messages (among others, of course): KL:INET 139 SYSTEM; So, clearly, there is something wrong with either ITS or CONFIG. It doesn’t create a binary, and thus, we never (in the KL build) created a new ITS. We simply got the MX one that we got off the binary bootstrap tape. I’ll try to track this down. Not sure if it is a bug in your ITS changes, or a bug in the CONFIG for KL yet. |
Turns out there was an extra |
With my fixes to ITS and CONFIG, I can boot a KL instance now that correctly gets MYCHDR set. I will, with your permission, update this branch/PR. Please let me know if ok. |
Aaargh. Sorry about that! Weird about the BUGTAB though? But please go ahead! |
The new conditional for CH10P must have added one or two BUGHLTs that KL didn’t have before. |
just like CH11 does (see PR #2038) Fixed mismatched bracket in SYSTEM;ITS and bumped version number. Also bumped version number on SYSTEM;CHAOS.
27a4f57
to
f6d9444
Compare
@larsbrinkhoff Please let me know if you are now happy with this PR (@bictorv too). I combined Victor's original commit with a commit with only the fix to ITS and the bumps of the version numbers. And I made the second commit be just the CONFIG change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Approved.
just like CH11 does (see PR #2038). This makes it easier to change a system's address (e.g. for joining the Global Chaosnet).
(Version numbers should be bumped.)