Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CH10 pick up address from interface #2293

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Conversation

bictorv
Copy link
Contributor

@bictorv bictorv commented Mar 18, 2024

just like CH11 does (see PR #2038). This makes it easier to change a system's address (e.g. for joining the Global Chaosnet).

(Version numbers should be bumped.)

@larsbrinkhoff
Copy link
Member

Thank you. I will check this, but I'll be busy the coming weeks so it may be a while.

@eswenson1
Copy link
Member

I haven't actually built and tested this on a CH10 system yet. Will do that next.

Copy link
Member

@eswenson1 eswenson1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried testing this out by build an EMULATOR=pdp10-kl version of ITS. The network didn't come up, and I noticed that MYCHDR wasn't defined. It turned out that the ITS built by this build was configured for the machine MX and not KL, and MX doesn't have the chaosnet definitions, as KL does. I'm going to debug this and fix.

So let's not merge this until I've proven that it works on either a pdp10-kl or a pdp10-ka ITS.

Also, you need to update the version number on chaos.290 and its.1651.

@eswenson1 eswenson1 marked this pull request as draft March 20, 2024 16:20
@eswenson1
Copy link
Member

In the booted KL instance, I manually tried to build ITS. I see the following messages (among others, of course):

KL:INET 139 SYSTEM;
IPMTU1+2 55003 3. 10-034 Amazing MIT-Specific crocks near IPMTU.!
..
==> INSERTED: INET 139
==> INSERTED: TCP 276
==> INSERTED: CHSDEF 15
==> INSERTED: CHAOS 290
==> INSERTED: NET 33
==> INSERTED: ITSMSP 30
==> INSERTED: TS3TTY 402
==> INSERTED: ITSDEV 977
==> INSERTED: EVSYMS 21
==> INSERTED: CORE 82
==> INSERTED: SYSJOB 119
HIGHEST USED = 171460
SPACE LEFT IN UPT = 13
STORAGE PER LOSER = 1000
KL:ITS 1651 SYSTEM;
BUGBUG+5 174430 1. 305-081 Stray ]
IEND 175000 1. 309-036 MAKE THE BUGTAB BIGGER
LBUGTB-LBUGT2 = 2
IEND 175000 1. 309-038 FATAL ERROR, RUNNING THIS WOULD CAUSE T!
OTALLY WEIRD BUGS
Run time = ,.^N7
9134 Symbols including initial ones (76% used)

So, clearly, there is something wrong with either ITS or CONFIG. It doesn’t create a binary, and thus, we never (in the KL build) created a new ITS. We simply got the MX one that we got off the binary bootstrap tape.

I’ll try to track this down. Not sure if it is a bug in your ITS changes, or a bug in the CONFIG for KL yet.

@eswenson1
Copy link
Member

Turns out there was an extra ] -- where the double ]] is. Also, even if you fix that, you get an error that the BUGTAB needs to get increased in size. Fixing that allows a pdp10-kl build to build the ITS, which correctly gets CH10P defined as 1 and an ITSNMS table that matches the MCOND KL entry in CONFIG 202. However, that ITSNMS table needs to have a KL entry in it, and probably shouldn't have MC in it.

@eswenson1
Copy link
Member

With my fixes to ITS and CONFIG, I can boot a KL instance now that correctly gets MYCHDR set. I will, with your permission, update this branch/PR. Please let me know if ok.

@bictorv
Copy link
Contributor Author

bictorv commented Mar 20, 2024

Turns out there was an extra ] -- where the double ]] is.

Aaargh. Sorry about that! Weird about the BUGTAB though? But please go ahead!

@eswenson1
Copy link
Member

The new conditional for CH10P must have added one or two BUGHLTs that KL didn’t have before.

bictorv and others added 2 commits March 21, 2024 16:43
just like CH11 does (see PR #2038)

Fixed mismatched bracket in SYSTEM;ITS and bumped version number.
Also bumped version number on SYSTEM;CHAOS.
@eswenson1
Copy link
Member

@larsbrinkhoff Please let me know if you are now happy with this PR (@bictorv too).

I combined Victor's original commit with a commit with only the fix to ITS and the bumps of the version numbers. And I made the second commit be just the CONFIG change.

@larsbrinkhoff larsbrinkhoff marked this pull request as ready for review March 22, 2024 08:16
Copy link
Member

@larsbrinkhoff larsbrinkhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Approved.

@larsbrinkhoff larsbrinkhoff merged commit e5ee344 into master Mar 22, 2024
14 checks passed
@larsbrinkhoff larsbrinkhoff deleted the ch10-pickup-address branch March 22, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants