Skip to content

style: cargo fmt, so CI stops failing on every PR - #9

Draft
OxToF wants to merge 1 commit into
mainfrom
chore/cargo-fmt
Draft

style: cargo fmt, so CI stops failing on every PR#9
OxToF wants to merge 1 commit into
mainfrom
chore/cargo-fmt

Conversation

@OxToF

@OxToF OxToF commented Aug 16, 2026

Copy link
Copy Markdown
Owner

cargo fmt --all --check has been red on main, so Anchor Build & Lint fails on every PR — including branches that touch no Rust at all. Both PRs merged today (#7, #8) showed a red check they had no part in, and the job never got as far as the build it is named for.

A lint that is always red stops being read, which is the actual cost here.

Contents

Formatting only. cargo check is clean.

One change is not rustfmt's output: rustfmt read the FOUNDER_BORROW_CAP_BPS note as a continuation of the trailing comment on MAX_EXERCISE_FEE_BPS and indented it to column 45 — worse than what it replaced. It is now a plain block comment at the margin, which is what it was in intent.

🤖 Generated with Claude Code

`cargo fmt --all --check` has been red on main, which makes the Anchor
Build & Lint job fail on any branch that touches nothing Rust at all —
two PRs merged today both showed a red check they had no part in. A
lint that is always red stops being read.

Formatting only, no semantic change: `cargo check` clean.

One comment moved rather than reformatted. rustfmt treated the
FOUNDER_BORROW_CAP_BPS note as a continuation of the trailing comment on
MAX_EXERCISE_FEE_BPS and indented it to column 45, which is worse than
what it replaced. It is now a plain block comment at the margin, which
is what it always was in intent.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Aug 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
soladrome-lzn5 Ready Ready Preview Aug 16, 2026 12:32am

@OxToF

OxToF commented Aug 31, 2026

Copy link
Copy Markdown
Owner Author

Parking this as a draft rather than closing it: it is kept as research, not as pending work.

Status as of 2026-08-31: this branch reformats programs/soladrome/src/lib.rs and pol.rs. Both have moved since — lib.rs was split into constants/, state/ and instructions/ on refactor/audit-module-split, and cde5cb2 re-ran cargo fmt across the tree. The diff no longer applies as written.

The branch chore/cargo-fmt is preserved and untouched. Reopen with one click if the formatting question comes back.

@OxToF
OxToF marked this pull request as draft August 31, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant