This repository was archived by the owner on Aug 31, 2019. It is now read-only.
Fix maxNoDamageTicks being cut in half #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Missing two |
jedediah
force-pushed
the
fix-max-no-damage-ticks
branch
from
3e84b25 to
7a85230
Compare
|
added comments |
|
Looks good to merge |
|
One thing. Bukkit/CraftBukkit@bccc961 changed the damage API and mentioned the changes affecting noDamageTicks. Not sure exactly what they did, but would it be better to update SportBukkit? I updated it a while ago but it caused issues with our kill tracking. |
tonybruess
force-pushed
the
master
branch
2 times, most recently
from
012fd8f to
c24a0c6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For no apparent reason, noDamageTicks was counting down from maxNoDamageTicks to maxNoDamageTicks/2. Both of these values can be set through the Bukkit API, but there is no correction for this strange offset. As a result, the value passed to setMaxNoDamageTicks would effectively be cut in half, and the value passed to setNoDamageTicks would be reduced by maxNoDamageTicks/2.