Merged
Conversation
mpmcroy
reviewed
Mar 24, 2021
Contributor
mpmcroy
left a comment
mpmcroy
left a comment
There was a problem hiding this comment.
I like this idea!
I have one question in the comments that would help me understand how we want to treat these IDs.
Draft
mpmcroy
approved these changes
Mar 25, 2021
Contributor
mpmcroy
left a comment
mpmcroy
left a comment
There was a problem hiding this comment.
I like this change a lot 🔥
| delete(): Promise<void>; | ||
| // Returns the virtual host ID. | ||
| getHostId(): string; | ||
| } |
Contributor
There was a problem hiding this comment.
Can we update the Server#getId method to mention that this ID is unique across clouds?
fortuna
commented
Mar 25, 2021
| delete(): Promise<void>; | ||
| // Returns the virtual host ID. | ||
| getHostId(): string; | ||
| } |
fortuna
commented
Mar 25, 2021
Collaborator
Author
fortuna
left a comment
fortuna
left a comment
There was a problem hiding this comment.
Oh, I see you approved. I'll submit once the CI is done.
Contributor
|
Thanks for this refactor!! I like where this is atm, but if you want to explore it a bit more, let me know and I'll take another look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches from using isManaged to using account ids.
This should help with the follow up to #848, since you will need to ensure unique server ids.
Things to note:
This approach may simplify your GCP UI PR by allowing the accounts to be handled the same way.
For example, we could fire a "AccountSignOutRequested' with an accountId, which can pull the account and call account.disconnect(). You'd need an Account interface in that case.
Perhaps the app-root dom tree can be done by two nested dom-repeat.