feat(server): add server manager install script to support rootless docker#1293
Draft
Friend-LGA wants to merge 5 commits intoOutlineFoundation:masterfrom
Draft
feat(server): add server manager install script to support rootless docker#1293Friend-LGA wants to merge 5 commits intoOutlineFoundation:masterfrom
Friend-LGA wants to merge 5 commits intoOutlineFoundation:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
fortuna
requested changes
Mar 8, 2023
Collaborator
fortuna
left a comment
There was a problem hiding this comment.
Thanks for the contribution. However, there are a few issues:
- It doesn't fully work. If one changes the port for access keys, Docker won't be mapping those new ports, so it won't work. That's why we use
--net host. We also need that to determine what ports are in use. - It loses the history, so I can't tell what the differences are from the original script
- It introduces a lot of duplicate code to maintain
You need to address those issues in order for us to consider merging the contributions.
Why do you need Rootless mode in the first place?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now default install flow is using this script
sudo bash -c "$(wget -qO- https://raw.githubusercontent.com/Jigsaw-Code/outline-server/master/src/server_manager/install_scripts/install_server.sh)"This one doesn't work with Rootless Docker because of 2 reasons:
--net hostflagwatchtowerThis PR adds new script
install_server_rootless.shwhich maps docker ports directly using-pflag and removes usage ofwatchtower.Works with Rootless Docker (tested).
Example usage
bash -c "SHADOWBOX_DIR=$HOME/outline-data $(wget -qO- https://raw.githubusercontent.com/Jigsaw-Code/outline-server/master/src/server_manager/install_scripts/install_server_rootless.sh)"Notice no
sudois here and custom shadowbox dir.