Skip to content

chore: fix linter#2712

Merged
fortuna merged 5 commits intomasterfrom
lint-eslintrc-clean
Feb 23, 2026
Merged

chore: fix linter#2712
fortuna merged 5 commits intomasterfrom
lint-eslintrc-clean

Conversation

@fortuna
Copy link
Collaborator

@fortuna fortuna commented Feb 23, 2026

Summary:

  • add targeted ESLint overrides for JS config/build files outside TS project coverage
  • keep type-aware linting for in-project files
  • include server_manager/www/app.spec.ts in server_manager/tsconfig.json

We can now call npm run lint:gts and npm run format:all from macOS, which is helpful for AI.

Validation:

  • npm run action server_manager/electron/build -- --buildMode=debug
  • npm run action server_manager/test
  • npx eslint server_manager/www/app.spec.ts
  • npx tsc -p server_manager/tsconfig.json --noEmit

@fortuna fortuna changed the title lint: fix parser project mismatches for config files chore: fix linter Feb 23, 2026
@fortuna fortuna requested review from Copilot and ohnorobo February 23, 2026 04:10
@fortuna fortuna marked this pull request as ready for review February 23, 2026 04:10
@fortuna fortuna requested a review from a team as a code owner February 23, 2026 04:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes linter configuration to enable npm run lint:gts on macOS by properly handling JavaScript config/build files that are outside TypeScript project coverage. The changes remove the exclusion of app.spec.ts from the server_manager TypeScript project and add ESLint overrides to disable type-aware linting for JavaScript configuration files.

Changes:

  • Added ESLint overrides for JavaScript config/build files not covered by TypeScript projects
  • Removed exclusion of server_manager/www/app.spec.ts from server_manager/tsconfig.json
  • Removed macOS-specific warnings from npm scripts in package.json

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
.eslintrc.json Added overrides section to disable type-aware linting for JavaScript config/build files outside TypeScript projects
server_manager/tsconfig.json Removed exclusion of app.spec.ts to include it in TypeScript project for linting
package.json Removed macOS-specific warnings from format:all and lint:gts scripts

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@ohnorobo ohnorobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@fortuna fortuna enabled auto-merge (squash) February 23, 2026 16:28
@fortuna fortuna merged commit 50d7a8c into master Feb 23, 2026
23 checks passed
@fortuna fortuna deleted the lint-eslintrc-clean branch February 23, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants