Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes linter configuration to enable npm run lint:gts on macOS by properly handling JavaScript config/build files that are outside TypeScript project coverage. The changes remove the exclusion of app.spec.ts from the server_manager TypeScript project and add ESLint overrides to disable type-aware linting for JavaScript configuration files.
Changes:
- Added ESLint overrides for JavaScript config/build files not covered by TypeScript projects
- Removed exclusion of
server_manager/www/app.spec.tsfromserver_manager/tsconfig.json - Removed macOS-specific warnings from npm scripts in
package.json
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.eslintrc.json |
Added overrides section to disable type-aware linting for JavaScript config/build files outside TypeScript projects |
server_manager/tsconfig.json |
Removed exclusion of app.spec.ts to include it in TypeScript project for linting |
package.json |
Removed macOS-specific warnings from format:all and lint:gts scripts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ohnorobo
approved these changes
Feb 23, 2026
Contributor
ohnorobo
left a comment
There was a problem hiding this comment.
Thank you for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We can now call
npm run lint:gtsandnpm run format:allfrom macOS, which is helpful for AI.Validation: