Skip to content

package-lock check adding#4086

Open
Bojan131 wants to merge 16 commits intov8/developfrom
package-lock-check
Open

package-lock check adding#4086
Bojan131 wants to merge 16 commits intov8/developfrom
package-lock-check

Conversation

@Bojan131
Copy link
Collaborator

@Bojan131 Bojan131 commented Jan 21, 2026

package-lock check adding


Note

Introduces graceful shutdown hooks, CI validation for dependencies, and more reliable BDD test lifecycle.

  • Core shutdowns: http-client now tracks server handle and exposes close(); network libp2p-service adds stop(); managers (httpClientModuleManager, networkModuleManager) expose close/stop. New cleanupBlockchainIntervals utility used by ProofingService and ClaimRewardsService via cleanup().
  • CI: New workflow check-package-lock.yml verifies package-lock.json presence, non-empty, and sync via npm ci --dry-run. BDD checks add redis service.
  • Tests: MockOTNode gains stop() to shutdown executor, HTTP, network, and clean intervals. BDD steps/hooks refactored to stop nodes before cleanup, handle bootstrap errors, pass blockchain config to clients, and ignore expected libp2p rejections.

Written by Cursor Bugbot for commit 2aa0df9. This will update automatically on new commits. Configure here.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link
Collaborator

@AnaDjokovic AnaDjokovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, just check and resolve the copilot suggestions

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants