Blog Post 2 - #2
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a second blog post and improves blog/MDX rendering with per-post theming and richer code block styling (including Expressive Code integration).
Changes:
- Add a new MDX blog post and wire blog cards/pages to use per-post
colormetadata. - Introduce markdown-specific styling (inline code, blockquotes, list markers) and extend theme background variables.
- Upgrade Astro + MDX-related deps and add
astro-expressive-codeintegration for enhanced code blocks.
Reviewed changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/styles/markdown.css | New base-layer styles for rendered markdown content (code, blockquotes, markers, expressive-code wrapper). |
| src/styles/global.css | Adds additional --background-* tokens for use by markdown/code styling. |
| src/pages/blog/index.astro | Uses each post’s data.color when rendering the Card list. |
| src/pages/blog/[slug].astro | Imports markdown styles, applies per-post CSS color var, passes description to layout, adjusts blog article styling, and removes custom MDX component mapping. |
| src/content/blog/002.beforeinstallprompt.mdx | Adds “Blog Post 2” content. |
| src/components/content/ContentUl.astro | Forwards props to <ul> (MDX wrapper behavior change). |
| src/components/content/ContentP.astro | Forwards props to <p> (MDX wrapper behavior change). |
| src/components/content/ContentLi.astro | Forwards props to <li> (MDX wrapper behavior change). |
| src/components/content/ContentH1.astro | Forwards props and tweaks nested code styling. |
| src/components/content/ContentH2.astro | Forwards props and tweaks nested code styling. |
| src/components/content/ContentH3.astro | Forwards props and tweaks nested code styling. |
| src/components/content/ContentH4.astro | Forwards props and tweaks nested code styling. |
| src/components/content/ContentH5.astro | Forwards props and tweaks nested code styling. |
| src/components/content/ContentH6.astro | Forwards props and tweaks nested code styling. |
| src/components/content/ContentCode.astro | New wrapper component for <code> (currently not wired into rendering). |
| src/components/ContentComponents.astro | Adds code mapping to the MDX components map (but map appears unused after page changes). |
| package.json | Bumps Astro/MDX/RSS/Sitemap versions and adds astro-expressive-code. |
| astro.config.mjs | Configures Expressive Code themes/selectors and adds markdown Shiki config. |
| pnpm-lock.yaml | Lockfile updates for dependency bumps and new integration. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
src/components/ContentComponents.astro:18
- After removing the import/usage from the blog post page, this
componentsmapping doesn’t appear to be referenced anywhere insrc/(search forContentComponents/components={returns no matches). Either wire this back into MDX rendering (e.g., pass it toContent) or delete the file/components to avoid carrying unused code.
export const components = {
h1: ContentH1,
h2: ContentH2,
h3: ContentH3,
h4: ContentH4,
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.