feat(lib): Inherits the dark/light theme's mode management using css variables and an ODS Charts DEFAULT mode #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louismaximepiton
force-pushed
the
main-lmp-handle-dark-mode-library
branch
3 times, most recently
from
980c81e to
59df041
Compare
|
Perhaps it would be possible to do as in the example https://www.w3schools.com/howto/howto_html_include.asp to mutualize header and footer code? This is optional, perhaps to be dealt with at a later date. |
9 tasks
2 tasks
jacques-lebourgeois
force-pushed
the
main-lmp-handle-dark-mode-library
branch
from
4b60ac5 to
258b347
Compare
✅ Deploy Preview for ods-charts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jacques-lebourgeois
force-pushed
the
main-lmp-handle-dark-mode-library
branch
from
258b347 to
acfb9ef
Compare
jacques-lebourgeois
changed the title
jacques-lebourgeois
force-pushed
the
main-lmp-handle-dark-mode-library
branch
3 times, most recently
from
a2aad1f to
f605f4a
Compare
jacques-lebourgeois
force-pushed
the
main-lmp-handle-dark-mode-library
branch
from
f605f4a to
9516175
Compare
…variables and an ODS Charts DEFAULT mode
louismaximepiton
force-pushed
the
main-lmp-handle-dark-mode-library
branch
from
9516175 to
f9a8f32
Compare
louismaximepiton
commented
Jan 3, 2025
| color: ['#B5E8F7', '#80CEEF', '#4BB4E6', '#3E9DD6', '#237ECA', '#085EBD'], | ||
| color: [ | ||
| 'var(--ods-blue-100, #B5E8F7)', | ||
| 'var(--ods-blue-200, #80CEEF)', |
There was a problem hiding this comment.
Suggested change
| 'var(--ods-blue-200, #80CEEF)', | |
| 'var(--ods-blue-200)', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please transform
- [ ]into- (NA)in the description when things are not applicableRelated issues
NA
Description
TODO
Motivation & Context
Be able to use Boosted contextual dark mode to use ODS Charts dark mode. And handle the mode so it looks like Boosted v5.
Types of change
Test checklist
Please check that the following tests projects are still working:
docs/examplestest/angular-ngx-echartstest/angular-echartstest/htmltest/reacttest/vuetest/examples/bar-line-charttest/examples/single-line-charttest/examples/timeseries-chart