Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): bad and duplicated alt names on images #2835

Merged

Conversation

nilloq
Copy link
Member

@nilloq nilloq commented Jan 9, 2025

Related issues

#2792

Description

Change alt attributes on images to:

  • match the image text content
  • have separate alt attributes on two different images

Motivation & Context

Improve accessibiliy

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

Close #2792

@nilloq nilloq linked an issue Jan 9, 2025 that may be closed by this pull request
3 tasks
Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 43275d1
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/677fc6cd2045fe0008b787bb
😎 Deploy Preview https://deploy-preview-2835--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes 🎉 @MewenLeHo are you fine with the changes ?

@MewenLeHo
Copy link
Contributor

LGTM!
Thanks.
🚀

@louismaximepiton louismaximepiton merged commit 9c06ea4 into main Jan 16, 2025
16 checks passed
@louismaximepiton louismaximepiton deleted the main-sc-2792-bad-accessible-names-on-two-image-links branch January 16, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Bad accessible names on two image links
3 participants