chore(merge main): patched commit → 0cbfe13 #2828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louismaximepiton
added
v5
dependencies
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
louismaximepiton
added
chore
merge
louismaximepiton
force-pushed
the
main-merge-bootstrap-58f2df8
branch
from
9594d81 to
2120af5
Compare
louismaximepiton
force-pushed
the
main-merge-bootstrap-58f2df8
branch
from
70f67c5 to
2120af5
Compare
vprothais
reviewed
Dec 26, 2024
scss/_carousel.scss
Outdated
| @@ -355,7 +356,7 @@ | |||
| left: (100% - $carousel-caption-width) * .5; | |||
| padding: $carousel-caption-padding-y $carousel-caption-padding-x; // Boosted mod | |||
| color: $carousel-caption-color; | |||
| background-color: $carousel-caption-bg; // Boosted mod | |||
| background-color: $carousel-caption-bg; // Boosted mod: instead of `var(--#{$prefix}carousel-caption-color)` | |||
There was a problem hiding this comment.
On the bootstrap side the change was on the color, not the background color but there is no background color on Bootstrap side. Shouldn't we update the color instead ?
There was a problem hiding this comment.
Good catch ! I've changed the comment so we aren't lost. Since we already properly take care of the dark mode carousel in Boosted, I didn't change anything.
vprothais
approved these changes
Dec 27, 2024
vprothais
force-pushed
the
main-merge-bootstrap-58f2df8
branch
from
243a160 to
1cff6e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
twbs/bootstrap@1d92d0b: Nothing to do