Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): add checks and radios without labels #1228

Merged
merged 2 commits into from
May 3, 2022

Conversation

hannahiss
Copy link
Member

@hannahiss hannahiss commented Apr 29, 2022

Closes #1127

@hannahiss
Copy link
Member Author

I'm not sure if it has to be done: it is asked in issue #901 but code specifies:
<!-- Boosted mod: don't promote "without label" -->

@julien-deramond julien-deramond added v5 fix 📖 documentation Improvements or additions to documentation labels May 2, 2022
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah your right about it, I don't have any idea about this one. Maybe we should warn about it with an ODS alert ? Any thoughts @julien-deramond ?

@julien-deramond julien-deramond force-pushed the main-his-check-radios-no-labels branch from f4f9178 to c8fa9e4 Compare May 3, 2022 05:20
@julien-deramond julien-deramond self-requested a review May 3, 2022 05:24
Copy link
Contributor

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it is not really related to ODS constraints so let's bring it back as it is.

@julien-deramond julien-deramond merged commit 94ce2c8 into main May 3, 2022
@julien-deramond julien-deramond deleted the main-his-check-radios-no-labels branch May 3, 2022 05:32
@julien-deramond julien-deramond mentioned this pull request May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation fix v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs > Forms > Checks & radios Missing Without labels from Bootstrap
3 participants