Fix remap_tiles_for_output() for -W16 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where the tile data output was squished and missing even columns when converting a SNES tileset with a `-W 16` argument. This commit also fixes a segfault when converting a snes tileset with `-W 8 -H 16` (when _tile_width is 8 `(cells_per_tile_h - 2)` underflows).
|
This PR does not fix the 16px map bug reported in #34 The tiles are now correct. The map data is still incorrect. Test image: Before (v0.11.0): After: |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug when converting SNES tiles with the
-W16argument.It also fixes a segfault when converting tiles with
-W8 -H16arguments.EDIT: This PR has not been tested with non SNES tiles and it has not been tested with a tile size > 16 pixels.
Source image:
Before (v0.11.0):
After:
