Add support for Sega Master System and Game Gear #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optiroc
reviewed
Dec 4, 2024
| case Mode::gg: | ||
| v.push_back(entry.tile_index & 0xff); | ||
| v.push_back(((entry.tile_index >> 8) & 0x01) | (entry.flip_h << 1) | (entry.flip_v << 2) | ((entry.palette_index << 3) & 0x8)); | ||
| // SMS and GG support depth information per tile in tilemap, instead of per sprite. But superfamiconv doesn't provide that rope? |
There was a problem hiding this comment.
I will have to look into the specifics and see if that's something that can be supported.
Optiroc
approved these changes
Dec 4, 2024
Optiroc
requested changes
Dec 4, 2024
src/Mode.h
Outdated
| case Mode::sms: | ||
| v.push_back(((color >> 12) & 0x30) | ((color >> 6) & 0x0C) | (color & 3)); | ||
| break; | ||
| case Mode::pv1k: |
There was a problem hiding this comment.
It's how you know I didn't re-build after cherry-picking the SMS support away from the PV-1000 support :sigh:
|
Thanks for the PR! Looking good, but there's one stray reference to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's tested support for Sega's Master System and Game Gear VDP layouts