Open
Conversation
qbojj
force-pushed
the
interrupt-handler
branch
3 times, most recently
from
7b1ea39 to
a2af9e8
Compare
qbojj
force-pushed
the
interrupt-handler
branch
4 times, most recently
from
7f3eef4 to
c191cca
Compare
qbojj
force-pushed
the
interrupt-handler
branch
20 times, most recently
from
854a0a7 to
780ca2c
Compare
frogrammer9
requested changes
Mar 11, 2026
src/kernel/interrupt/trap_handler.c
Outdated
Contributor
There was a problem hiding this comment.
I would rather wait for #64 to be merged and move it to an appropriate directory in the hal structure.
Contributor
There was a problem hiding this comment.
To be honest i don't really like this being a lib, this makes more sense to me as a kernel module. Right now it is fine, especially when examples use this. But i would restructure it.
qbojj
force-pushed
the
interrupt-handler
branch
from
2b24b2a to
198f97b
Compare
qbojj
force-pushed
the
interrupt-handler
branch
2 times, most recently
from
59cb844 to
60040ef
Compare
qbojj
force-pushed
the
interrupt-handler
branch
from
aa2d2f8 to
b2b4938
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.