Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): fix no tiprack-related whitescreen #17373

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

ncdiehl11
Copy link
Collaborator

Overview

This PR fixes a PD whitescreen bug where a user tries to create a transfer step wihout a tiprack available on the deck. As a temporary fix, I null check the first tiprack option in TiprackField and default to a placeholder string. This prevents a whitescreen, and creates a not-enough-tips timeline error if the step is saved, instructing the user to add tipracks to the deck to fix.

Closes RESC-380

Test Plan and Hands on Testing

  • create a protocol with a wellplate
  • delete all tiprack instances
  • create a transfer step and verify that no whitescreen occurs, and that the tiprack field defaults to "No tiprack available"
  • fill out the form and save
  • verify that a not-enough-tips timeline error is shown

Changelog

  • null check tiprack list in TiprackField
  • add translation

Review requests

see test plan

Risk assessment

low

This PR fixes a PD whitescreen bug where a user tries to create a transfer step wihout a tiprack available on the deck. As a temporary fix, I null check the first tiprack option in `TiprackField` and default to a placeholder string. This prevents a whitescreen, and creates a not-enough-tips timeline error if the step is saved, instructing the user to add tipracks to the deck to fix.

Closes RESC-380
@ncdiehl11 ncdiehl11 self-assigned this Jan 28, 2025
@ncdiehl11 ncdiehl11 requested review from koji and jerader January 28, 2025 21:25
@ncdiehl11 ncdiehl11 marked this pull request as ready for review January 28, 2025 21:25
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner January 28, 2025 21:25
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, do we follow the same pattern for when there are no lawares available for that dropdown? i feel like we say "choose option" or something

@ncdiehl11
Copy link
Collaborator Author

lgtm, do we follow the same pattern for when there are no lawares available for that dropdown? i feel like we say "choose option" or something

Yes we show a dropdown option that is not Interactable. I just brought this up with Mel who is giving it a think. For now, the resolution is to leave it alone.

@ncdiehl11 ncdiehl11 merged commit fd9b628 into edge Jan 28, 2025
24 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_pd-tiprack-whitescreen branch January 28, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants