fix(app): fix manual move to location with module #17283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-3839
Overview
Fixes a bug in which manually moving labware to a module was moving the labware off-deck. Turns out that one of the lower level utils was specifying an invalid param to
getPositionFromSlotId: themoduleIdinstead of theAddressableAreaName, ex. "A3".Unfortunately, it's we can't really update the interface for this util to require an
AddressableAreaName, because the util is utilized in so many places that pass instrings and notAddressableAreaNamesthat this quickly becomes unmanageable for a quick bug fix. I've left a TODO here in the meantime.Current Behavior
Screen.Recording.2025-01-15.at.4.17.58.PM.mov
Fixed Behavior
Screen.Recording.2025-01-15.at.4.16.02.PM.mov
Test Plan and Hands on Testing
Changelog
Risk assessment
low