Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): magnetic block can be added to staging area slot #17242

Merged
merged 5 commits into from
Jan 15, 2025

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Jan 10, 2025

closes AUTH-978

Overview

Now you can add magnetic block to a staging area in both editing you deck setup and the onboarding flow

Test Plan and Hands on Testing

Test different combos in the onboarding flow to see that it correctly places staging area with the magnetic block
Test adding a magnetic block and staging area in deck setup

Changelog

  • extend logic to accept magnetic block on a staging area
  • add test coverage for available slots

Risk assessment

low

@jerader jerader marked this pull request as ready for review January 13, 2025 15:15
@jerader jerader requested a review from a team as a code owner January 13, 2025 15:15
@jerader jerader requested review from koji and ncdiehl11 January 13, 2025 15:15
@ncdiehl11
Copy link
Collaborator

looking for designs here— do we intend to lump together mag block and staging area in the same deck fixture?

@jerader
Copy link
Collaborator Author

jerader commented Jan 13, 2025

looking for designs here— do we intend to lump together mag block and staging area in the same deck fixture?

yup! @ncdiehl11 sorry here are the designs. realized my copy is a bit wrong. i'll update it. https://www.figma.com/design/WbkiUyU8VhtKz0JSuIFA45/Feature%3A-Protocol-Designer-Phase-1?node-id=6640-50018&t=2bfdm9pzLrJl2UkH-0

Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works well. I'm not as familiar with the logic for determining available slots during protocol creation, but smoke tested without issue. I'm comfortable merging this

protocol-designer/src/pages/Designer/DeckSetup/utils.ts Outdated Show resolved Hide resolved
@jerader jerader added the DO NOT MERGE Indicates a PR should not be merged, even if there's a shiny green merge button available label Jan 13, 2025
@jerader jerader requested a review from a team as a code owner January 15, 2025 00:20
@jerader jerader changed the base branch from edge to chore_release-pd-8.3.0 January 15, 2025 00:20
@jerader jerader removed the DO NOT MERGE Indicates a PR should not be merged, even if there's a shiny green merge button available label Jan 15, 2025
@jerader jerader changed the title feat(protocol-designer): magnetic block be added to staging area slot feat(protocol-designer): magnetic block can be added to staging area slot Jan 15, 2025
@jerader jerader merged commit a87b3b3 into chore_release-pd-8.3.0 Jan 15, 2025
61 checks passed
@jerader jerader deleted the pd_magnetic-block-3rd-column branch January 15, 2025 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants