feat(robot-server): separate can logs from other serial logs (#16686)

Opentrons · Nov 5, 2024 · beede80 · beede80
1 parent 86f6547
commit beede80
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 1 deletion.
diff --git a/api/src/opentrons/util/logging_config.py b/api/src/opentrons/util/logging_config.py
@@ -36,7 +36,7 @@ def _host_config(level_value: int) -> Dict[str, Any]:
                 "class": "logging.handlers.RotatingFileHandler",
                 "formatter": "basic",
                 "filename": serial_log_filename,
-                "maxBytes": 5000000,
+                "maxBytes": 1000000,
                 "level": logging.DEBUG,
                 "backupCount": 3,
             },

diff --git a/robot-server/robot_server/health/router.py b/robot-server/robot_server/health/router.py
@@ -30,6 +30,7 @@
 ]
 FLEX_LOG_PATHS = [
     "/logs/serial.log",
+    "/logs/can_bus.log",
     "/logs/api.log",
     "/logs/server.log",
     "/logs/update_server.log",

diff --git a/robot-server/robot_server/service/legacy/models/logs.py b/robot-server/robot_server/service/legacy/models/logs.py
@@ -6,6 +6,7 @@ class LogIdentifier(str, Enum):
 
     api = "api.log"
     serial = "serial.log"
+    can = "can_bus.log"
     server = "server.log"
     api_server = "combined_api_server.log"
     update_server = "update_server.log"

diff --git a/robot-server/robot_server/service/legacy/routers/logs.py b/robot-server/robot_server/service/legacy/routers/logs.py
@@ -14,6 +14,7 @@
     LogIdentifier.api_server: "opentrons-robot-server",
     LogIdentifier.update_server: "opentrons-update-server",
     LogIdentifier.touchscreen: "opentrons-robot-app",
+    LogIdentifier.can: "opentrons-api-serial-can",
 }
 
 

diff --git a/robot-server/tests/integration/fixtures.py b/robot-server/tests/integration/fixtures.py
@@ -50,6 +50,7 @@ def check_ot3_health_response(response: Response) -> None:
         "board_revision": "UNKNOWN",
         "logs": [
             "/logs/serial.log",
+            "/logs/can_bus.log",
             "/logs/api.log",
             "/logs/server.log",
             "/logs/update_server.log",