Skip to content

Improved integer square root: Rewrite comments from #4403 #4902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Amxx wants to merge 27 commits into from
+0 −0
Closed

Improved integer square root: Rewrite comments from #4403 #4902

Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
171e5c2
Improved integer square root.
chgorman Jun 29, 2023
beec057
Small updates to sqrt function.
chgorman Jul 22, 2023
a48fda8
Merge branch 'master' into master
Amxx Jul 24, 2023
b6c29b1
Fixed variable naming.
chgorman Jul 24, 2023
0d2bbb3
Added some comments to help clarify the algorithm.
chgorman Jul 24, 2023
1c8e8ab
Updated edge case for clarity.
chgorman Jul 25, 2023
8e2ab78
Made small improvements.
chgorman Aug 31, 2023
77db52d
Merge branch 'master' into master
chgorman Jan 22, 2024
8b3f15f
Added additional comments to include associated proof.
chgorman Feb 13, 2024
dc098e8
Merge branch 'master' into master
ernestognw Feb 13, 2024
bd9d969
Reduce sqrt comments
ernestognw Feb 14, 2024
dfe2fbc
Lint
ernestognw Feb 14, 2024
a53d378
Correcting return logic
chgorman Feb 14, 2024
6c74012
remove overflow check (early) in favor of overflow save math at the e…
Amxx Feb 14, 2024
fe8abc3
format
Amxx Feb 14, 2024
382ab6f
Iterate on comments
ernestognw Feb 15, 2024
c60542b
Iterate on comments
ernestognw Feb 15, 2024
ddea292
Lint
ernestognw Feb 15, 2024
360f65d
Codespell
ernestognw Feb 15, 2024
4288c74
Iterate on comments
ernestognw Feb 15, 2024
256189a
rewrite most comments of the sqrt function
Amxx Feb 15, 2024
6d00bbd
improve
Amxx Feb 15, 2024
6c8be26
shift notation e+1 → e
Amxx Feb 15, 2024
67d0328
complete proof
Amxx Feb 15, 2024
85a56d6
improvement
Amxx Feb 15, 2024
e748bfc
remove reference to Heron's method to avoid confusion
Amxx Feb 16, 2024
b20585a
Merge branch 'master' into math/sqrt-root-comments
ernestognw Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

These merge commits were added into this branch cleanly.

There are no new changes to show.