fix(vad): guard unknown field limits and normalize context in whisperVadConfig - #1926
Open
hsusul wants to merge 1 commit into
Open
fix(vad): guard unknown field limits and normalize context in whisperVadConfig#1926hsusul wants to merge 1 commit into
hsusul wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1925
Problem
In
src/helpers/whisperVadConfig.js:clampVadField(key, value)unconditionally indexedLIMITS[key], throwingTypeError: Cannot destructure property 'min' of 'LIMITS[key]'if an unlisted or custom configuration field was passed.resolveContextSileroEnabled(settings, context)compared against literal"dictation","noteRecording", and"meeting", failing to recognize mixed-case or whitespace-padded context strings.Solution
LIMITS[key]before destructuring min/max limits..trim().toLowerCase().test/helpers/whisperVadConfig.test.js.Verification
node --test test/helpers/whisperVadConfig.test.js(passes, 5/5 tests)npm run typecheck(passes, 0 errors)npm run lint(passes, 0 errors)npm run i18n:check(passes)npm run build:renderer(passes)git diff --check(clean)