fix(dictionary): accept Set/iterable snapshots and guard non-string words (#1880) - #1923
Open
dominikake wants to merge 1 commit into
Open
fix(dictionary): accept Set/iterable snapshots and guard non-string words (#1880)#1923dominikake wants to merge 1 commit into
dominikake wants to merge 1 commit into
Conversation
…ords in agentNameDictionary (OpenWhispr#1880) Issue OpenWhispr#1880: agentNameDictionaryChanges only accepted arrays, so a Set or other iterable dictionary silently degraded to [] and wrongly suggested adding the name. findStoredWord also threw on a non-string word. - Coerce arrays, Sets, and other iterables to a word list (excluding strings); degrades other inputs to [] without throwing. - Guard findStoredWord against non-string words (returns undefined). - Add unit tests for Set, Map-key, and non-iterable inputs, plus a findStoredWord non-string guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1880.
agentNameDictionaryChangesonly acceptedstring[], so aSetor other iterable dictionary snapshot silently degraded to[]and wrongly suggested adding the name.findStoredWordalso threwTypeError: word.toLowerCase is not a functionon a non-string word.agentNameDictionaryChangesnow coerces arrays,Sets, and other iterables to a word list (strings and non-iterables degrade to[]without throwing).findStoredWordguards against non-stringword(returnsundefined).Set,Map-key iterator, non-iterable, and non-string-element inputs, plus afindStoredWordnon-string guard.Verification
node --import tsx --test "test/helpers/agentNameDictionary.test.js"→ 21 passingnpm run quality-check→ passes (format + typecheck)npm run i18n:check→ passesThis supersedes the failing PR #1881 with an equivalent fix that is prettier-clean.
🤖 Generated with OpenCode