fix(assistant): normalize requestId and add input guards in AgentStreamRequestRegistry - #1920
Open
hsusul wants to merge 1 commit into
Open
Conversation
…amRequestRegistry (OpenWhispr#1919)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1919
Problem
In
src/helpers/agentStreamRequestRegistry.js:begin(senderId, requestId)validated thatrequestId.trim()was non-empty, but stored the untrimmed string. If a request was registered with surrounding whitespace and cancelled without it (or vice versa), the controller lookup missed and the active stream failed to abort.cancel,complete, andcancelSenderdid not guard against invalid types (e.g. non-integersenderIdor non-stringrequestId).Solution
requestIdwith.trim()consistently acrossbegin,cancel, andcomplete.senderIdandrequestIdacross registry methods.test/helpers/agentStreamRequestRegistry.test.js.Verification
node --test test/helpers/agentStreamRequestRegistry.test.js(passes, 7/7 tests)npm run typecheck(passes, 0 errors)npm run lint(passes, 0 errors)npm run i18n:check(passes)npm run build:renderer(passes)git diff --check(clean)