fix(meetings): Add swipe dismissal to meeting notifications - #1906
Merged
Conversation
Recreates #1897, which was reverted in #1904, on top of #1898. A horizontal pointer swipe of 80px in either direction dismisses the notification card, taking the same path as its close button. Swipes that start on an action button are ignored, and the window stays interactive for the duration of a captured drag so leaving the card mid-swipe does not make it click-through. #1897 exempted the auto-end countdown, which was non-dismissible then. #1898 replaced it with the restart offer, which has a close button, so the swipe routes through the same dismiss handler the button uses rather than the detection-only responder — which would have silently no-opped on that card. The dismissibility of the card under the pointer when it is released decides, since a newer prompt can replace the card mid-drag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The swipe now goes through one
dismisscallback that dispatches ondata.kind, shared with the card's close button, so a swipe does exactly what the X does on every card. The dismissibility check at pointer-up is kept because a newer prompt can replace the card mid-drag.Verification
npm run typecheckclean.src) and Prettier clean on the changed files.