Skip to content

fix(audio): validate settings and finite duration in shouldSaveDiscardedRecording #1806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hsusul wants to merge 1 commit into from
Closed

fix(audio): validate settings and finite duration in shouldSaveDiscardedRecording #1806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/helpers/discardedRecording.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@ import {
export const MIN_DISCARDED_DURATION_SECONDS = 1;

export function shouldSaveDiscardedRecording(settings, durationSeconds, policyState = null) {
if (!settings) return false;
if (!settings || typeof settings !== "object") return false;
if (!Number.isFinite(durationSeconds) || durationSeconds < MIN_DISCARDED_DURATION_SECONDS) {
return false;
}
const dataRetentionEnabled = policyState
? effectiveLocalHistoryEnabled(policyState, settings.dataRetentionEnabled)
: settings.dataRetentionEnabled;
Expand All @@ -18,6 +21,5 @@ export function shouldSaveDiscardedRecording(settings, durationSeconds, policySt
if (!settings.saveDiscardedTranscriptions) return false;
if (!dataRetentionEnabled) return false;
if (!(audioRetentionDays > 0)) return false;
if (!(durationSeconds >= MIN_DISCARDED_DURATION_SECONDS)) return false;
return true;
}
10 changes: 8 additions & 2 deletions test/helpers/discardedRecording.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,16 @@ test("saves when all gates pass and duration >= threshold", async () => {
assert.equal(shouldSaveDiscardedRecording(base, MIN_DISCARDED_DURATION_SECONDS), true);
});

test("does not save below the minimum duration", async () => {
test("does not save below the minimum duration or with non-finite duration", async () => {
const { shouldSaveDiscardedRecording } = await load();
assert.equal(shouldSaveDiscardedRecording(base, 0.5), false);
assert.equal(shouldSaveDiscardedRecording(base, 0), false);
assert.equal(shouldSaveDiscardedRecording(base, -5), false);
assert.equal(shouldSaveDiscardedRecording(base, null), false);
assert.equal(shouldSaveDiscardedRecording(base, NaN), false);
assert.equal(shouldSaveDiscardedRecording(base, Infinity), false);
assert.equal(shouldSaveDiscardedRecording(base, -Infinity), false);
assert.equal(shouldSaveDiscardedRecording(base, "10"), false);
});

test("respects each gate", async () => {
Expand All @@ -33,10 +37,12 @@ test("respects each gate", async () => {
assert.equal(shouldSaveDiscardedRecording({ ...base, audioRetentionDays: 0 }, 3), false);
});

test("handles missing settings", async () => {
test("handles missing or non-object settings", async () => {
const { shouldSaveDiscardedRecording } = await load();
assert.equal(shouldSaveDiscardedRecording(null, 3), false);
assert.equal(shouldSaveDiscardedRecording(undefined, 3), false);
assert.equal(shouldSaveDiscardedRecording("invalid", 3), false);
assert.equal(shouldSaveDiscardedRecording(123, 3), false);
});

test("uses the policy-effective history setting without changing raw settings", async () => {
Expand Down
Loading