Skip to content

Enhance platform detection in windows? method #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enhance platform detection in windows? method #245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions lib/puppet/util/platform.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,13 @@ module Platform
WINDOWS_FIPS_REGISTRY_KEY = 'System\\CurrentControlSet\\Control\\Lsa\\FipsAlgorithmPolicy'

def windows?
# Ruby only sets File::ALT_SEPARATOR on Windows and the Ruby standard
# library uses that to test what platform it's on. In some places we
# would use Puppet.features.microsoft_windows?, but this method can be
# used to determine the behavior of the underlying system without
# requiring features to be initialized and without side effect.
!!File::ALT_SEPARATOR
# This used to look solely at File::ALT_SEPARATOR, as this was only populated on
# Windows Ruby. However, this is not a reliable check when attempting to run things
# inside Cygwin or MSys2. Ruby generally uses RUBY_PLATFORM these days to check
# platform type, e.g.
# https://github.com/ruby/ruby/blob/6e2906f60da20d6cd057aa8ad4b84f8c988406d9/ext/socket/lib/socket.rb#L698
# In our builds, RUBY_PLATFORM = x64-mingw32 and in tests run via Cygwin, x86_64-cygwin.
!(RUBY_PLATFORM =~ /mswin|mingw|cygwin/).nil?
end
module_function :windows?

Expand Down