Drop warning when using bolt as a gem #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The group within the github image is `runner`, not `docker`.
In the past people complained a lot about this warning and I don't see a reason why it's there, so we can just remove it. If you use the gem instead of packages, we assume a certain level of knowledge.
bastelfreak
force-pushed
the
bolt_gem
branch
from
f2c3c0f to
7a91ff7
Compare
|
It makes sense to notify user that bolt gem was executed, not the one from a package e.g. I saw different behaviour when bolt was executed as a gem, because it was brought by pdk (litmus). This warning saved a lot of debugging time. I'd prefer if bolt behaves in the same way in any case.. but it's not possible at the moment.. |
|
Do you remember what kind of different behaviour you noticed? |
|
IIRC, it was related to missing modules (stdlib e.g.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past people complained a lot about this warning and I don't see a reason why it's there, so we can just remove it. If you use the gem instead of packages, we assume a certain level of knowledge.