-
Notifications
You must be signed in to change notification settings - Fork 8
Mod Compatibility Fixes #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in this PR do not reflect how Victoria 2 works.
Carefully research Victoria 2 instead of trusting in mods.
Mods often just use things without realising it doesn't work.
558e096
to
73423c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid custom callbacks for invalid keys. Use the default handling instead.
Either map_key_value_invalid_callback
or map_key_value_ignore_invalid_callback
140000d
to
723b780
Compare
Everywhere that you use |
723b780
to
e2b908a
Compare
e2b908a
to
c9031cd
Compare
c9031cd
to
6697b0c
Compare
replace_path
when searching for files