Skip to content

Mod Compatibility Fixes #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

Mod Compatibility Fixes #291

merged 2 commits into from
Jun 11, 2025

Conversation

BrickPi
Copy link
Contributor

@BrickPi BrickPi commented Feb 3, 2025

  • Implements a "ModManager" which loads .mod files
  • Implements replace_path when searching for files
  • Myriad changes to better reflect how V2 handles systems
  • HPM now successfully loads and runs under OpenVic

@BrickPi BrickPi added the enhancement New feature or request label Feb 3, 2025
Copy link
Contributor

@wvpm wvpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this PR do not reflect how Victoria 2 works.
Carefully research Victoria 2 instead of trusting in mods.
Mods often just use things without realising it doesn't work.

@BrickPi BrickPi requested a review from wvpm March 24, 2025 17:40
@BrickPi BrickPi force-pushed the improve-mod-loading branch from 558e096 to 73423c5 Compare March 24, 2025 17:43
Copy link
Contributor

@wvpm wvpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid custom callbacks for invalid keys. Use the default handling instead.
Either map_key_value_invalid_callback or map_key_value_ignore_invalid_callback

@BrickPi BrickPi force-pushed the improve-mod-loading branch 3 times, most recently from 140000d to 723b780 Compare June 10, 2025 23:31
@BrickPi BrickPi requested a review from wvpm June 10, 2025 23:34
@Spartan322
Copy link
Member

Spartan322 commented Jun 11, 2025

Everywhere that you use std::vector<T> const& could you instead use std::span<T> as it reduces indirection and generalizes the use case instead of being dependent on the vector type being passed. It would allow any contiguous finite array of elements, dynamic or static, to be passed in and also doesn't depend on an allocator to describe the type.

@BrickPi BrickPi force-pushed the improve-mod-loading branch from 723b780 to e2b908a Compare June 11, 2025 04:17
Spartan322
Spartan322 previously approved these changes Jun 11, 2025
wvpm
wvpm previously approved these changes Jun 11, 2025
@BrickPi BrickPi merged commit c8bac29 into master Jun 11, 2025
16 checks passed
@BrickPi BrickPi deleted the improve-mod-loading branch June 11, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request topic:dataloader
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants