#377 Competencies page should display previous reflections table#408
#377 Competencies page should display previous reflections table#408MahoMori wants to merge 21 commits into
Conversation
…category and summary columns.
…cording to the category name
…e route to CompetenciesView page according to the discussion today
…s-reflections-table
…tenciesDetailTable component
…s-reflections-table
…ompare labels with competencies to show the right rating
…ns-table' of github.com:OpenTree-Education/rhizone-lms into 377-competencies-page-should-display-previous-reflections-table
…s-reflections-table
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
The table looks great! Really like the colour scheme for the 5 categories.
Great work Maho :)
achichikalova
left a comment
achichikalova
left a comment
There was a problem hiding this comment.
Excellent work, Maho!
I love the table; it looks neat and clean.
I have some questions about empty lines; it looks like you are using it to separate different parts of code, but not everywhere. In my opinion, we need to be more consistent with our code.
Nazanin-Rezaei
left a comment
Nazanin-Rezaei
left a comment
There was a problem hiding this comment.
It was a colorful design for UI but some extra line needed to be removed from the code.
| @@ -38,6 +38,18 @@ const StyledRating = styled(Rating)({ | |||
| }, | |||
| }); | |||
|
|
|||
| categoryDescription, | ||
| competencies, | ||
| }: DetailTableProps) => { | ||
| const [open, setOpen] = React.useState(false); |
There was a problem hiding this comment.
useState can directly be destructured in the import so that useState() can be utilized directly instead of React.useState()
There was a problem hiding this comment.
Good point! I changed code to import useState
| <Grid container justifyContent="center"> | ||
| <Grid item xs={12}> | ||
| <Box textAlign="center"> | ||
| <Button variant="contained" sx={{ my: 5 }}> |
There was a problem hiding this comment.
What page should the user be shown on clicking this "Take Assessment" button?
There was a problem hiding this comment.
I believe it takes to the assessment page with five pictures (CategoriesCompetenciesPage.tsx which @achichikalova was working on).
seidior
changed the title
4 participants
Proposed changes
Closes #376, #377 and #383
This shows a page which includes:
##Screenshot
The last two screenshots are taken by merging 377 branch to Shea's prototype to check the function.
Checklist