Skip to content

Embed images via next-images #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Embed images via next-images #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...c/sharing-images/website-into-sharing.png → assets/open-graph-image.png
View file
Open in desktop
File renamed without changes
3 changes: 2 additions & 1 deletion components/Meta.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import PropTypes from 'prop-types'
import Head from 'next/head'
import useTranslation from '../hooks/useTranslation'
import openGraphImage from '../assets/open-graph-image.png'

export default function Meta({ pageTitle, pageDescription, pageImage }) {
const { t } = useTranslation()
Expand All @@ -22,7 +23,7 @@ export default function Meta({ pageTitle, pageDescription, pageImage }) {
<meta
property='og:image'
content={`https://www.opentechschool.org${pageImage ||
'/sharing-images/website-into-sharing.png?1'}`}
openGraphImage}`}
/>
<meta name='twitter:card' content='summary_large_image' />
<meta name='twitter:site' content='@OpenTechSchool' />
Expand Down
5 changes: 3 additions & 2 deletions next.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
const path = require('path')
const withImages = require('next-images')

module.exports = {
module.exports = withImages({
webpack: function(config) {
config.module.rules.push({
test: /\.md$/,
Expand All @@ -14,4 +15,4 @@ module.exports = {
MEETUP_URL: 'http://meetup.com',
},
},
}
})
41 changes: 41 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
"fetch-jsonp": "^1.1.3",
"gray-matter": "^4.0.2",
"next": "^9.3.5",
"next-images": "^1.4.0",
"raw-loader": "^4.0.1",
"react": "^16.13.1",
"react-dom": "^16.13.1",
Expand Down