Skip to content

Conversation

@Elblinator
Copy link
Member

@Elblinator Elblinator commented Oct 14, 2025

resolves #5324
needs [https://github.com/OpenSlides/openslides-autoupdate-service/pull/1274]
and [https://github.com/OpenSlides/openslides-backend/pull/3164]

  • csv export missing
  • xlsl export missing

@Elblinator Elblinator added this to the 4.3 milestone Oct 14, 2025
@Elblinator Elblinator self-assigned this Oct 14, 2025
@Elblinator Elblinator added enhancement General enhancement which is neither bug nor feature Schrödinger projectname labels Oct 14, 2025
@Elblinator Elblinator assigned luisa-beerboom and MSoeb and unassigned Elblinator Oct 15, 2025
@Elblinator Elblinator marked this pull request as ready for review October 15, 2025 10:58
@Elblinator
Copy link
Member Author

found by @MSoeb
Deleted users cannot be deleted right now

@Elblinator Elblinator assigned Elblinator and unassigned luisa-beerboom and MSoeb Oct 15, 2025
@Elblinator Elblinator assigned luisa-beerboom and MSoeb and unassigned Elblinator Oct 16, 2025
Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as intended

@MSoeb MSoeb removed their assignment Oct 16, 2025
@Elblinator Elblinator added the waiting Waiting for some other PR/feature; more details in comments label Oct 16, 2025
@Elblinator
Copy link
Member Author

Waitng for the backend issue/ independent testing OpenSlides/openslides-backend#3164

Copy link
Member

@luisa-beerboom luisa-beerboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed some relatively minor stuff. If any of my remarks don't work or you don't see them as practival for whatever reason, feel free to tell me

Comment on lines 243 to 244
} else if (model.getTitle() === this.translate.instant(`Deleted user`)) {
this._removeUsersMap[model.user_id] = model.id;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this even a possible case?
I don't see any new code causing model.getTitle() to display Deleted user (and translated no less), so would this even work?
Also I'd imagine if the getTitle says Deleted user, it must either be a person with a really funny name (who could be treated like any other user) or a motion meeting user link with no attached meeting user, which could therefore not have a user_id

Copy link
Member Author

@Elblinator Elblinator Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this even a possible case?

Yes, if a user is deleted (and not removed)
The string is inserted at motion-manage-motion-meeting-users.component.html
Yes it's also translated
this line is only called if the user has no user_id, hence the user is not a "real" user

a motion meeting user link with no attached meeting user, which could therefore not have a user_id

I do not know how to rcreate such a case
I tested it with a user who is not deleted but removed and that user is displayed like before

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I resolved it?

@Elblinator Elblinator assigned bastianjoel and MSoeb and unassigned Elblinator Oct 23, 2025
@Elblinator Elblinator requested review from bspekker and removed request for MSoeb October 24, 2025 06:56
@Elblinator Elblinator assigned bspekker and unassigned MSoeb Oct 24, 2025
Copy link

@bspekker bspekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue after creating a new user in one of the concerned fields: when saving the entry the edit doesn't close and an error will appear when trying to save again.

@bspekker bspekker assigned Elblinator and unassigned bastianjoel and bspekker Oct 24, 2025
@Elblinator Elblinator requested a review from bspekker October 27, 2025 16:12
@Elblinator Elblinator assigned bastianjoel and bspekker and unassigned Elblinator Oct 27, 2025
@Elblinator Elblinator requested review from luisa-beerboom and removed request for bastianjoel November 3, 2025 06:57
Copy link
Member

@luisa-beerboom luisa-beerboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor things

@Elblinator Elblinator merged commit a203316 into OpenSlides:main Nov 4, 2025
3 checks passed
@Elblinator Elblinator deleted the 5314-deleted-submitter branch November 10, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement General enhancement which is neither bug nor feature Schrödinger projectname waiting Waiting for some other PR/feature; more details in comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add reference for deleted accounts in submitters, spokesperson, and editors

5 participants