-
Notifications
You must be signed in to change notification settings - Fork 44
Inline pdf attachment export for motions #5354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Inline pdf attachment export for motions #5354
Conversation
client/src/app/gateways/export/pdf-document.service/pdf-document.service.ts
Show resolved
Hide resolved
...etings/pages/motions/pages/motion-export/components/motion-export/motion-export.component.ts
Outdated
Show resolved
Hide resolved
...ings/pages/motions/pages/motion-export/components/motion-export/motion-export.component.html
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the changes:
If "Include..." is clicked:
-
Page layout options Table of contents, Continous Text should be deactivated. (I think, the other options hsould work even with pdf file export.)
-
Header and footer: Page numbers should be deactivated. Header and current date for the normal motion pdfs should stay.
-
Option for "Include" should only be available, if a PDF file is attached to a selected motion. (Follows logic of other options)
-
Option "include" should not be a default selection. (If this currently integrated ignore this point.)
Term changes:
- Attachments --> Attachments (URL)
- Include.. -> Attachments (PDF embedded)
Other problems which can, if possible should be solved:
- Voting result: Should only be available, if a selected motion have one. If available, not preselected, but open for selection. If not, not possible to select.
- Change of text version: the text option in content is deselected, if text version is changed. -> Text should stay selected.
For the record:
Other problems which we have seems to solved with this PR.
- Options which are not available in a motion are correctly not choosable. (Supporters, Motion editors, speaker, recommendation, Category, Tags, Motions block, linked motions). In the live version these options are correctly not choosable, but the visual set them nevertheless as chosen and preselected.
We do not load all attachment data on the motion list. Therefore this is now only disabled when there are no attachments at all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We talked about this behaviour a bit:
Conlcusion:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The snackbar currently flickers, display multiple times and shows quite late the info that a PDF is exported.
Wanted: Only one snackbar with the pdf export text should be shown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flickering of snackback during export with attachments happens still.
...eetings/pages/motions/services/export/motion-pdf-export.service/motion-pdf-export.service.ts
Outdated
Show resolved
Hide resolved
…rt/motion-pdf-export.service/motion-pdf-export.service.ts Co-authored-by: Loki Elble <[email protected]>
But it should be minor now. IMHO the effort needed to fix this is not worth it. |
5f4c131
to
6c59388
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code
resolves #4798
closes #5274