Skip to content

Conversation

bastianjoel
Copy link
Member

@bastianjoel bastianjoel commented Aug 28, 2025

resolves #4798
closes #5274

@Elblinator Elblinator assigned bastianjoel and unassigned Elblinator and MSoeb Sep 1, 2025
Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the changes:

If "Include..." is clicked:

  • Page layout options Table of contents, Continous Text should be deactivated. (I think, the other options hsould work even with pdf file export.)

  • Header and footer: Page numbers should be deactivated. Header and current date for the normal motion pdfs should stay.

  • Option for "Include" should only be available, if a PDF file is attached to a selected motion. (Follows logic of other options)

  • Option "include" should not be a default selection. (If this currently integrated ignore this point.)

Term changes:

  • Attachments --> Attachments (URL)
  • Include.. -> Attachments (PDF embedded)

Other problems which can, if possible should be solved:

  • Voting result: Should only be available, if a selected motion have one. If available, not preselected, but open for selection. If not, not possible to select.
  • Change of text version: the text option in content is deselected, if text version is changed. -> Text should stay selected.

For the record:
Other problems which we have seems to solved with this PR.

  • Options which are not available in a motion are correctly not choosable. (Supporters, Motion editors, speaker, recommendation, Category, Tags, Motions block, linked motions). In the live version these options are correctly not choosable, but the visual set them nevertheless as chosen and preselected.

@bastianjoel
Copy link
Member Author

Option for "Include" should only be available, if a PDF file is attached to a selected motion. (Follows logic of other options)

We do not load all attachment data on the motion list. Therefore this is now only disabled when there are no attachments at all.

Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Export dialog: If a motion doesn't contain an attachment, the export dialog still shows the marked option, even it is not choosable anymore.

--> Wanted: All options which are currently not available for export should be in the visual scheme of the Attachments (URL) button. See image below.

Screenshot_20250905_134749

@MSoeb MSoeb assigned bastianjoel and unassigned Elblinator and MSoeb Sep 5, 2025
@Elblinator
Copy link
Member

We talked about this behaviour a bit:

  1. The chips remember their state in between meetings in general and this should be fixed in it's own issue
  2. The disabled but selected chips maybe should not have the blue checkbox and should stay as there are right now, this will be discussed a bit more and will be probably fixed in the issue mentioned above
  3. @MSoeb will think a bit more about the functionality here and if the chip should be selected or not if it's impossible to export pdfs

Conlcusion:

  1. A new issue will be created
  2. No further coding is needed until @MSoeb says how the client should behave here

Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The snackbar currently flickers, display multiple times and shows quite late the info that a PDF is exported.

Wanted: Only one snackbar with the pdf export text should be shown.

@MSoeb MSoeb assigned bastianjoel and unassigned Elblinator and MSoeb Sep 9, 2025
@bastianjoel bastianjoel requested a review from MSoeb September 9, 2025 15:42
@bastianjoel bastianjoel assigned Elblinator and MSoeb and unassigned bastianjoel Sep 9, 2025
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code

Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flickering of snackback during export with attachments happens still.

@MSoeb MSoeb removed their assignment Sep 15, 2025
…rt/motion-pdf-export.service/motion-pdf-export.service.ts

Co-authored-by: Loki Elble <[email protected]>
@bastianjoel
Copy link
Member Author

Flickering of snackback during export with attachments happens still.

But it should be minor now. IMHO the effort needed to fix this is not worth it.

@bastianjoel bastianjoel assigned MSoeb and unassigned bastianjoel Sep 30, 2025
@bastianjoel bastianjoel force-pushed the 4708-motion-attachment-export branch from 5f4c131 to 6c59388 Compare October 9, 2025 08:40
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Motion-list: Allow to export PDF inside of other PDFs

3 participants