Slider #9907
Open
Slider #9907
+129
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9907 +/- ##
===========================================
+ Coverage 81.53% 87.50% +5.97%
===========================================
Files 1059 31 -1028
Lines 104459 1537 -102922
Branches 722 0 -722
===========================================
- Hits 85166 1345 -83821
+ Misses 19252 192 -19060
+ Partials 41 0 -41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
anisometropie
force-pushed
the
vcs/space-time-h-slider
branch
3 times, most recently
from
2bc8a57 to
fcc21dc
Compare
anisometropie
force-pushed
the
vcs/space-time-h-slider
branch
3 times, most recently
from
9b7fd35 to
6ad1af5
Compare
emersion
reviewed
Jan 8, 2025
| @@ -50,6 +55,7 @@ type ManchetteWithSpaceTimeChartProps = { | |||
| export const MANCHETTE_WITH_SPACE_TIME_CHART_DEFAULT_HEIGHT = 561; | |||
| const BOTTOM_TOOLBAR_HEIGHT = 40; | |||
| const SPACE_TIME_CHART_DIFF_HEIGHT = 8; | |||
| const DEFAULT_ZOOM_MS_PER_PX = 7500; | |||
There was a problem hiding this comment.
Seems like this const is imported from osrd-ui above?
There was a problem hiding this comment.
yes, was just waiting for the ui release
Signed-off-by: Valentin Chanas <[email protected]>
anisometropie
force-pushed
the
vcs/space-time-h-slider
branch
from
6ad1af5 to
d3ce176
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9723
Requires OpenRailAssociation/osrd-ui#805 + release to be merged ✔️