Use consists parameters to train simulation request

[Wadjetz]

fix #9544

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 91.58879% with 9 lines in your changes missing coverage. Please review.

Project coverage is 81.49%. Comparing base (384dcea) to head (78ec705).
Report is 21 commits behind head on dev.

Files with missing lines	Patch %	Lines
editoast/src/views/path/pathfinding.rs	65.00%	7 Missing ⚠️
editoast/src/views/timetable/stdcm.rs	92.00%	2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #9660      +/-   ##
==========================================
- Coverage   81.53%   81.49%   -0.05%     
==========================================
  Files        1059     1061       +2     
  Lines      104491   104609     +118     
  Branches      722      722              
==========================================
+ Hits        85198    85247      +49     
- Misses      19252    19321      +69     
  Partials       41       41              

Flag	Coverage Δ
editoast	73.61% <91.42%> (-0.14%)	⬇️
front	89.25% <100.00%> (+<0.01%)	⬆️
gateway	2.18% <ø> (ø)
osrdyne	3.28% <ø> (ø)
railjson_generator	87.50% <ø> (ø)
tests	87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[flomonster]

You have three functions (train_simulation_batch, get_train_batch_simulation and consist_train_simulation_batch). Only two of them are required.

• train_simulation_batch(&[TrainSchedule])
  • Retrieve rolling stocks from rolling_stock_name field`
  • Convert this rolling stocks into PhysicsConsistParameters
  • Call consist_train_simulation_batch
• consist_train_simulation_batch(&[TrainScheduleWithPhysicsConsist])
  • Check valkey cache
  • Call the pathfinding
  • Cal the simulation
  • Cache the response
  • Return the response

[hamz2a]

LGTM, thanks!

[leovalais]

Cursory review. I'll come back to this when @flomonster's comments are addressed. Meanwhile, a few comments (mostly about excessive cloning 😄):

(The PR name and commit messages aren't really helpful to understand what's being fixed exactly, and it's not front: commits 😅)

[flomonster]

Thanks.

We need to make sure that the function parameters are as logical and relevant as possible (avoid hacks, as this suits our workflow).

[woshilapin]

Just left some comments, needs a more thorough review still.

[leovalais]

LGTM, thanks for the changes!

[flomonster]

LGTM