Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: display duration time only for requested pathsteps #10264

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

SarahBellaha
Copy link
Contributor

@SarahBellaha SarahBellaha commented Jan 7, 2025

Closes #9981

@SarahBellaha SarahBellaha requested a review from a team as a code owner January 7, 2025 08:13
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.43%. Comparing base (b09fc36) to head (5d98e7b).
Report is 10 commits behind head on dev.

Files with missing lines Patch % Lines
...cations/stdcm/utils/formatSimulationReportSheet.ts 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10264      +/-   ##
==========================================
- Coverage   81.44%   81.43%   -0.02%     
==========================================
  Files        1058     1058              
  Lines      104282   104286       +4     
  Branches      722      722              
==========================================
- Hits        84936    84923      -13     
- Misses      19305    19322      +17     
  Partials       41       41              
Flag Coverage Δ
editoast 73.57% <ø> (-0.05%) ⬇️
front 89.18% <20.00%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Caracol3 Caracol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested :)

@SarahBellaha SarahBellaha added this pull request to the merge queue Jan 7, 2025
Merged via the queue into dev with commit 00e4d5f Jan 7, 2025
27 checks passed
@SarahBellaha SarahBellaha deleted the sba/front/fix-op-stop-duration-9981 branch January 7, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ops considered as stops when they aren't in stdcm result table
4 participants