core, editoast, python: stop train on next signal instead of OP #10200
+217
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:railjson
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10200 +/- ##
==========================================
- Coverage 81.49% 81.47% -0.02%
==========================================
Files 1058 1041 -17
Lines 104270 103635 -635
Branches 722 722
==========================================
- Hits 84970 84435 -535
+ Misses 19259 19159 -100
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
louisgreiner
force-pushed
the
lgr/fix-train-switch-overflow
branch
3 times, most recently
from
03bbd62 to
101da24
Compare
louisgreiner
force-pushed
the
lgr/fix-train-switch-overflow
branch
5 times, most recently
from
a3b0127 to
c06ea7a
Compare
Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
…serializer Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
louisgreiner
force-pushed
the
lgr/fix-train-switch-overflow
branch
3 times, most recently
from
e428743 to
5a5ff11
Compare
Signed-off-by: Louis Greiner <[email protected]>
louisgreiner
force-pushed
the
lgr/fix-train-switch-overflow
branch
from
5a5ff11 to
18a57e2
Compare
Signed-off-by: Louis Greiner <[email protected]>
louisgreiner
commented
Jan 8, 2025
Comment on lines
+18
to
+19
| #[derivative(Default(value = "true"))] | ||
| #[serde(default = "default_stop_at_next_signal")] |
There was a problem hiding this comment.
Suggested change
| #[derivative(Default(value = "true"))] | |
| #[serde(default = "default_stop_at_next_signal")] | |
| #[derivative(Default(value = "false"))] |
Comment on lines
+27
to
+29
| fn default_stop_at_next_signal() -> bool { | ||
| true | ||
| } |
There was a problem hiding this comment.
Suggested change
| fn default_stop_at_next_signal() -> bool { | |
| true | |
| } |
| @@ -149,6 +149,7 @@ const useSetupItineraryForTrainUpdate = (trainIdToEdit: number) => { | |||
| rolling_stock_supported_signaling_systems: rollingStock.supported_signaling_systems, | |||
| rolling_stock_maximum_speed: rollingStock.max_speed, | |||
| rolling_stock_length: rollingStock.length, | |||
| stop_at_next_signal: true, // TODO: change to false and set to true elsewhere if needed | |||
There was a problem hiding this comment.
Suggested change
| stop_at_next_signal: true, // TODO: change to false and set to true elsewhere if needed | |
| stop_at_next_signal: false, |
| @@ -79,6 +79,7 @@ export const getPathfindingQuery = ({ | |||
| rolling_stock_supported_signaling_systems: rollingStock.supported_signaling_systems, | |||
| rolling_stock_maximum_speed: rollingStock.max_speed, | |||
| rolling_stock_length: rollingStock.length, | |||
| stop_at_next_signal: true, // TODO: change to false and set to true elsewhere if needed | |||
There was a problem hiding this comment.
Suggested change
| stop_at_next_signal: true, // TODO: change to false and set to true elsewhere if needed | |
| stop_at_next_signal: false, |
|
Questions :
|
Signed-off-by: Louis Greiner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/osrd-project/osrd-confidential/issues/892
Closes https://github.com/osrd-project/osrd-confidential/issues/830
Depends on https://gitlab-repo-res.apps.eul.sncf.fr/dsir/groupedxs-dsir/04735/etl_basic/-/merge_requests/145 for internal use
Note : the following screenshots are for review visualization only, nothing will be output in the front-end at the end
The train stops are now shifted the least possible to the next signal position, with a minimal value that would put the tail of the train on the operational point.
Examples:
With a
TGV2N2, 400m trainWith a
83500, 109m train