front: refacto stdcm op schedule #10192
Open
+141
−219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10192 +/- ##
===========================================
+ Coverage 81.53% 87.50% +5.97%
===========================================
Files 1059 31 -1028
Lines 104459 1537 -102922
Branches 722 0 -722
===========================================
- Hits 85166 1345 -83821
+ Misses 19252 192 -19060
+ Partials 41 0 -41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
clarani
force-pushed
the
cni/10190-refacto-stdcm-op-schedule
branch
2 times, most recently
from
2c31a7d to
b5f5574
Compare
clarani
force-pushed
the
cni/10190-refacto-stdcm-op-schedule
branch
from
daac10b to
b5f5574
Compare
clarani
force-pushed
the
cni/10190-refacto-stdcm-op-schedule
branch
2 times, most recently
from
b8af3cb to
3a36df3
Compare
SharglutDev
reviewed
Jan 7, 2025
front/src/applications/stdcm/components/StdcmForm/StdcmOpSchedule.tsx
Outdated
Show resolved
Hide resolved
clarani
force-pushed
the
cni/10190-refacto-stdcm-op-schedule
branch
from
3a36df3 to
ccd7409
Compare
SharglutDev
reviewed
Jan 7, 2025
SharglutDev
reviewed
Jan 7, 2025
This was referenced Jan 8, 2025
clarani
force-pushed
the
cni/10190-refacto-stdcm-op-schedule
branch
2 times, most recently
from
b6412be to
4481c3a
Compare
SharglutDev
approved these changes
Jan 8, 2025
Maymanaf
reviewed
Jan 8, 2025
front/tests/utils/setup-utils.ts
Outdated
| @@ -177,8 +177,8 @@ export async function createDataForTests(): Promise<void> { | |||
|
|
|||
| const stdcmEnvironment = { | |||
| infra_id: smallInfra.id, | |||
| search_window_begin: '2024-10-17T00:00:00Z', | |||
| search_window_end: '2024-10-18T23:59:59Z', | |||
| search_window_begin: new Date('2024-10-17T00:00:01+02:00').toISOString(), | |||
There was a problem hiding this comment.
Why not directly use the calculated date?
'search_window_begin": "2024-10-16T22:00:01Z'
and
'search_window_end": "2024-10-18T21:59:59Z'
Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
…agement Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
clarani
force-pushed
the
cni/10190-refacto-stdcm-op-schedule
branch
from
695d82d to
4c5c097
Compare
clarani
force-pushed
the
cni/10190-refacto-stdcm-op-schedule
branch
from
4c5c097 to
577c2ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10190
See commits