-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix train selection in the anterior or posterior train list #10154
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10154 +/- ##
==========================================
- Coverage 81.44% 81.43% -0.01%
==========================================
Files 1058 1058
Lines 104268 104268
Branches 722 722
==========================================
- Hits 84916 84911 -5
- Misses 19311 19316 +5
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the issue is not in this function, it's because we should not receive a string if we're expecting a date.
I let you search a bit, the problem comes from the action updateLinkedTrainExtremity
, where we update the pathStep 😉
6648a3d
to
adfa631
Compare
Signed-off-by: theocrsb <[email protected]>
10ee3f8
to
74452ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested, LGTM :)
closes #10133