Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix train selection in the anterior or posterior train list #10154

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

theocrsb
Copy link
Contributor

closes #10133

@theocrsb theocrsb requested review from clarani and Akctarus December 20, 2024 11:01
@theocrsb theocrsb requested a review from a team as a code owner December 20, 2024 11:01
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.43%. Comparing base (58d7306) to head (74452ec).
Report is 9 commits behind head on dev.

Files with missing lines Patch % Lines
front/src/reducers/osrdconf/stdcmConf/index.ts 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10154      +/-   ##
==========================================
- Coverage   81.44%   81.43%   -0.01%     
==========================================
  Files        1058     1058              
  Lines      104268   104268              
  Branches      722      722              
==========================================
- Hits        84916    84911       -5     
- Misses      19311    19316       +5     
  Partials       41       41              
Flag Coverage Δ
editoast 73.60% <ø> (-0.02%) ⬇️
front 89.17% <50.00%> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the issue is not in this function, it's because we should not receive a string if we're expecting a date.

I let you search a bit, the problem comes from the action updateLinkedTrainExtremity, where we update the pathStep 😉

@theocrsb theocrsb force-pushed the tce/front/stdcm/bug-select-anterior-train branch from 6648a3d to adfa631 Compare January 3, 2025 10:16
@theocrsb theocrsb force-pushed the tce/front/stdcm/bug-select-anterior-train branch from 10ee3f8 to 74452ec Compare January 4, 2025 09:22
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, LGTM :)

@theocrsb theocrsb enabled auto-merge January 6, 2025 13:04
@theocrsb theocrsb added this pull request to the merge queue Jan 6, 2025
Merged via the queue into dev with commit f1e054a Jan 6, 2025
27 checks passed
@theocrsb theocrsb deleted the tce/front/stdcm/bug-select-anterior-train branch January 6, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STDCM: Can't select train for linked path
4 participants