front: handle train drag #10151
Open
front: handle train drag #10151
+286
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10151 +/- ##
===========================================
+ Coverage 81.44% 87.50% +6.06%
===========================================
Files 1058 31 -1027
Lines 104282 1537 -102745
Branches 722 0 -722
===========================================
- Hits 84930 1345 -83585
+ Misses 19311 192 -19119
+ Partials 41 0 -41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Math-R
force-pushed
the
mrd/handle-train-drag-2
branch
from
ed8a7a5 to
913bfb1
Compare
Math-R
force-pushed
the
mrd/handle-train-drag-2
branch
from
913bfb1 to
6607ec8
Compare
Math-R
force-pushed
the
mrd/handle-train-drag-2
branch
from
6607ec8 to
662dcf2
Compare
SharglutDev
reviewed
Jan 7, 2025
There was a problem hiding this comment.
Gonna start to check the code but after testing, I have some weird behaviors :
- When dragging a train to the left, the viewport follows the start of dragged train but it doesn't move if I drag the train to the right. Is it the expected behavior ?
Enregistrement.de.l.ecran.2025-01-07.a.08.47.25.mov
- If I pan to the right and then drag a train (which doesn't fit in viewport anymore), the viewport doesn't follow the drag. It seems it takes count only of the initial viewport position.
Enregistrement.de.l.ecran.2025-01-07.a.08.48.57.mov
- After dragging a train, a lot of endpoints are fired. I think we should just see the
putTrainScheduleById,summaries(only for the dragged train) and thegetTimetableByIdConflicts? It probably comes from the update which invalidates thetrain_scheduletag resulting to refetching all endpoints with this tag. This can maybe be handled by customizing the endpoint like in this PR. If you don't want to deal with that now, could you create an issue to handle that so we don't forget it ? :)
Enregistrement.de.l.ecran.2025-01-07.a.08.53.27.mov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.