front: stdcm max speed consist errors

Signed-off-by: Egor Berezovskiy <[email protected]>
OpenRailAssociation · Nov 7, 2024 · 10e5c5f · 10e5c5f
1 parent f0edf0f
commit 10e5c5f
Show file tree

Hide file tree

Showing 5 changed files with 44 additions and 4 deletions.
diff --git a/front/public/locales/en/stdcm.json b/front/public/locales/en/stdcm.json
@@ -19,6 +19,9 @@
         "negative": "Must be positive.",
         "lowerThanTractionEngine": "Must not be less than engine length.",
         "lowerThanConsist": "Must not be less than consist length."
+      },
+      "maxSpeed": {
+        "negative":  "Must be positive."
       }
     }
   },

diff --git a/front/public/locales/fr/stdcm.json b/front/public/locales/fr/stdcm.json
@@ -19,6 +19,9 @@
         "negative": "Doit être positif.",
         "lowerThanTractionEngine": "Ne doit pas être inférieur à la longueur de l'engin de traction.",
         "lowerThanConsist": "Ne doit pas être inférieur à la longueur du convoi."
+      },
+      "maxSpeed": {
+        "negative":  "Doit être positif."
       }
     }
   },

diff --git a/front/src/applications/stdcm/components/StdcmForm/StdcmConfig.tsx b/front/src/applications/stdcm/components/StdcmForm/StdcmConfig.tsx
@@ -179,7 +179,11 @@ const StdcmConfig = ({
                   <Button
                     label={t('simulation.getSimulation')}
                     onClick={startSimulation}
-                    isDisabled={!!consistErrors.totalMass || !!consistErrors.totalLength}
+                    isDisabled={
+                      !!consistErrors.totalMass ||
+                      !!consistErrors.totalLength ||
+                      !!consistErrors.maxSpeed
+                    }
                   />
                 )}
                 {formErrors && (

diff --git a/front/src/applications/stdcm/components/StdcmForm/StdcmConsist.tsx b/front/src/applications/stdcm/components/StdcmForm/StdcmConsist.tsx
@@ -5,7 +5,11 @@ import classNames from 'classnames';
 import { useTranslation } from 'react-i18next';
 
 import useStdcmTowedRollingStock from 'applications/stdcm/hooks/useStdcmTowedRollingStock';
-import { validateTotalLength, validateTotalMass } from 'applications/stdcm/utils/consistValidation';
+import {
+  validateMaxSpeed,
+  validateTotalLength,
+  validateTotalMass,
+} from 'applications/stdcm/utils/consistValidation';
 import type { LightRollingStockWithLiveries, TowedRollingStock } from 'common/api/osrdEditoastApi';
 import { useOsrdConfActions } from 'common/osrdContext';
 import SpeedLimitByTagSelector from 'common/SpeedLimitByTagSelector/SpeedLimitByTagSelector';
@@ -136,9 +140,10 @@ const StdcmConsist = ({ disabled = false }: StdcmConfigCardProps) => {
       updateConsistErrors({
         totalMass: totalMassError,
         totalLength: totalLengthError,
+        maxSpeed: validateMaxSpeed(maxSpeed),
       })
     );
-  }, [rollingStock, towedRollingStock, totalMass, totalLength]);
+  }, [rollingStock, towedRollingStock, totalMass, totalLength, maxSpeed]);
 
   return (
     <StdcmCard
@@ -228,7 +233,12 @@ const StdcmConsist = ({ disabled = false }: StdcmConfigCardProps) => {
           }
         />
       </div>
-      <div className="stdcm-consist__properties">
+      <div
+        className={classNames({
+          'stdcm-consist__properties': !consistErrors.maxSpeed,
+          'stdcm-consist_with_errors__properties': !!consistErrors.maxSpeed,
+        })}
+      >
         <SpeedLimitByTagSelector
           disabled={disabled}
           selectedSpeedLimitByTag={speedLimitByTag}
@@ -243,6 +253,14 @@ const StdcmConsist = ({ disabled = false }: StdcmConfigCardProps) => {
           min={0}
           value={maxSpeed ?? ''}
           onChange={onMaxSpeedChange}
+          statusWithMessage={
+            consistErrors?.maxSpeed
+              ? {
+                  status: 'error',
+                  message: t(consistErrors.maxSpeed),
+                }
+              : undefined
+          }
         />
       </div>
     </StdcmCard>

diff --git a/front/src/applications/stdcm/utils/consistValidation.ts b/front/src/applications/stdcm/utils/consistValidation.ts
@@ -52,3 +52,15 @@ export const validateTotalLength = (
 
   return undefined;
 };
+
+export const validateMaxSpeed = (maxSpeed?: number) => {
+  if (!maxSpeed) {
+    return undefined;
+  }
+
+  if (!maxSpeed || maxSpeed < 1) {
+    return 'consist.errors.maxSpeed.negative';
+  }
+
+  return undefined;
+};