Fixes for collapsed nodes support in main editor view #602
+204
−320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
force-pushed
the
emr/modify-node-display
branch
from
7a5a5a3 to
5aebc21
Compare
Signed-off-by: Simon Ser <[email protected]>
…hain Signed-off-by: Simon Ser <[email protected]>
TrainrunSectionViewObject will represent multiple trainrun sections soon. Add a helper to get the parent trainrun to reduce reliance on a single trainrun. Signed-off-by: Simon Ser <[email protected]>
This makes it clear that there isn't a single trainrun section per TrainrunSectionViewObject: a single TrainrunSectionViewObject can hold multiple sections. The full collapsed chain is stored. For now, blindly replace trainrunSection with trainrunSections[0], to be cleaned up in future commits. Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/modify-node-display
branch
from
5aebc21 to
6939966
Compare
Signed-off-by: Simon Ser <[email protected]>
Signed-off-by: Simon Ser <[email protected]>
The TrainrunSectionViewObject already contains the full chain, no need to re-compute it. Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/modify-node-display
branch
from
6939966 to
2aaeb51
Compare
louisgreiner
approved these changes
Nov 3, 2025
There was a problem hiding this comment.
Very nice, it makes the code easier, thanks
The path drawing is still missing some things, but I believe this does not belong to this PR to fix. Already discussed with @Math-R about it:
Math-R
approved these changes
Nov 3, 2025
|
@Math-R, note that another implementation of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
First two commits address #554 (comment)
Rest starts addressing the last paragraph of #554 (review)
Some more follow-up cleanups haven't been written yet.
Note, each time we access
TrainrunSectionViewObject.trainrunSections[0]needs to be re-evaluated to figure out whether we really should grab the first section, or the last one, or compute something over all sections (e.g. travel time).